Fix invalid expression for total count on inverse relationship filter from resource definition #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkoelman
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1711 +/- ##
=======================================
Coverage 90.64% 90.64%
=======================================
Files 355 355
Lines 11566 11569 +3
Branches 1908 1909 +1
=======================================
+ Hits 10484 10487 +3
Misses 706 706
Partials 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bkoelman
force-pushed
the
crashfix-total
branch
from
4148595 to
df417e7
Compare
… from resource definition
bkoelman
force-pushed
the
crashfix-total
branch
from
df417e7 to
ac31043
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the total count on a secondary/relationship endpoint is queried, and the primary filter originates from
IResourceDefinition.OnApplyFilter, the resulting expression is invalid. Since we're using the inverse relationship here, for many-to-many the solution is to move to the proper scope. For many-to-one endpoints, we cannot solve this, so do not return a total instead of crashing.Fixes #1671.
QUALITY CHECKLIST